Link titles always contain %2e and superflous slashes (needs urgent fix)

[merktnichts]

Using Hayes, appears in all released versions.

When you create a link, the generated link title tag always looks something like this: "%2e/Link/". This is somewhat irritating for users, it would be better to leave out the "%2e" (which you meant be a dot, I guess) and the slashes, as they are irrelevant to the user.

This appears to be a very minor annoyance, but should be fixed asap, because while filling the wiki all links you set contain this very bad formatting, so it's a lot of work to fix all contents after that bug is fixed in Deki. So (pretty) please put it very high onto your list, that would save hours of work for us as your customers/users. (That fix might be a bit late for me, as I have quite a lot of links already :()

Thanks a million! :)

[royk]

are you talking about in the link dialogs themselves or in the markup? the . and ./ are used for resolving "relative" links to the current page

[brigettek]

Good catch. The titles should actually only be displayed in edit mode and they were not getting url decoded. I will submit a fix for this shortly.

[merktnichts]

I'm talking about the "hover text" that comes up when you point the mouse cursor to a link without clicking. So I think it's the title tag in the anchor element.

Example:
<a class="internal" title="%2e/This_is_a_link/" rel="internal" href="http://xxxx/example_page/This_is_a_link">This is a link</a>

I just realized: It could be related to this bug (http://forums.opengarden.org/showthread.php?t=379) I reported which you were already able to reproduce (I'm not 100% sure, tho).
The hover text is correct in the left navigation pane and in the breadcrumbs, but contains the dots (or even %2e) and the slashes in links that are listed on a page.

I was just able to reproduce the following:

- Create a link called e.g. "Link with spaces" on a page, confirm the message about linking to an empty page
- Save the page
- Hover over the link, you'll see "./Link with spaces" as hover text (the user would expect "Link with spaces" as hover text)
- Edit the page again
- Save the page without doing anything else
- Hover over the link, you'll see "%2e/Link_with_spaces" as hover text (it should just be "Link with spaces" here as well), so the dot became a %2e
- Edit the page again
- Save the page without doing anything else
- Hover over the link, you'll see "%2e/Link_with_spaces/" as hover text, so a slash got appended
- Further dummy edits bring the same results now ("%2e/Link_with_spaces/")

In all cases the user would expect a plain "Link with spaces" as hover text.

Hope I explained it a bit better now. If not, just let me know and I'll try to find out better. ;)

Thanks a lot for investigating those flaws.

[merktnichts]

Good catch. The titles should actually only be displayed in edit mode and they were not getting url decoded. I will submit a fix for this shortly.
Well, I was writing a detailed explanation while you posted your answer already. ;) I'll recheck as soon as your fix is in SVN on SF.

[merktnichts]

brigettek/karena: Please see this post (http://forums.opengarden.org/showpost.php?p=1828&postcount=6) about the fix developer karena put into SVN. It's not fully fixed yet, details are in that post.

[brigettek]

Yup, I hadn't yet submitted the C# portion of the changes - they have been submitted in r5038-5041. The hovering titles should have actually only be shown in the editor and not during page view. Also, as you posted, they were not being properly decoded. I've updated the behavior to only show hovering titles in edit mode and to have them display the full decoded path.

We still seem to have a little editor issue with the ä in Internet Explorer. If i try to update links with ä in them, the link dialog opens with only the portion of the link before the ä. I have reactivated bug 2316 with this information.

[merktnichts]

Hehe, so I take it: brigettek==karena? :)

Sorry for not having been patient long enough for the C# part to be checked in, mea culpa. I didn't wanna push the crew. ;)

Anyway, as reported, one part is fixed. That's the part about proper encoding/decoding of the characters. Thanks a lot for that!

Nevertheless, one tiny issue remains. Please try the following (most transparent when using a page with links, I guess):

- edit an existing page with links on it
- write one or more words (e.g. Testlink), make it a link by hitting the "L" button in the editor
-> the dialog shows the existing links on the page and suggests our link to point to "./Testlink" - perfect & expected (please memorize this view)
- confirm the dialog & save the page
- hit edit again, edit the link you just created by hitting the "L" button
-> the dialog shows the (empty) link list of the (yet non-existing) page "./Testlink/" and it suggests our link to point to "./Testlink/" (compare this view now to the one you memorized 3 lines above)

The fact that the dialog shows an empty link list makes sense, as our link morphed from "./Testlink" to "./Testlink/", but that's just a result of the slash the editor unexpectedly appended to our link when entering the second edit run.

It all has no further consequences anymore, as the encoding is working as expected thanks to your previous fixes. The only "flaw" is that on second and subsequent edits the slash gets appended, making the link dialog show "one level too deep in the pages hierachy", which is confusing to the user who doesn't know he has to manually remove the slash in the link dialog's "Link:" input box. Also, it's not consistent through all edits (the first edit produces a different result than subsequent edits).

Does my (maybe too long & too complicated) explanation make sense to you? If not, let me know and I'd try to explain it again using screenshots. It's not that easy for me to explain such things in English, as it's not my mother tongue. But I'm trying my very best. ;)

(Btw, I didn't put it into mantis now, cause I started it in this thread already. Future reports will go directly to mantis - promised. :))

[AaronF]

LOL. No, Brigette is a woman. Kar'en is a man. :-)

Thanks a bunch for using Mantis. This helps us quite a bit.

[SteveB]

Thanks. I filed a bug report on it and linked it to this post: http://bugs.opengarden.org/view.php?id=2353

[brigettek]

The slash at the end was added to edit mode, so that the link dialog would always open into the page. As you pointed out, this navigation could be confusing. In r5601 I updated edit mode to no longer include a slash at the end.

We do now have a reverse glitch: if you use the link dialog to create a link ending in slash "./Testlink/", save, and open back up the editor, it will go to ./Testlink instead. The reason is that our internal link parsing resolves internal links to page titles and, in this case, both links correspond to the same page title. If this behavior raises issues for your scenario let me know.

[merktnichts]

Brigette, thanks a lot for the fix! I just gave it a quick check and it works! Amazing. ;)

I read your post and also the note you added in Mantis and will have an eye on if it will raise new issues. For now it looks like the fix is just perfect for our scenario. In case I come across something weird again, I'd let you know via Mantis.

Thanks again! /me is going to finally fix the links in our Deki now, as all bugs I found around linking seem to be solved now (from my memory). One more time: Amazing.