HttpHandler Initialization

[dani]

Hello,
I have installed a dream server as a HttpHandler in Asp.Net, and looking at the log messages it seems that the class HttpHandler is created 2 times and each time the IDreamEnvironment is also created.
I think that the problem is in SyncRoot and _env, which are defined as

private object SyncRoot = new object(); (httphandler.cs, line 48)
private IDreamEnvironment _env;

and maybe should be

private static object SyncRoot = new object();
private static IDreamEnvironment _env;

Is that correct?

[SteveB]

That's odd that it is being created twice. Do you know why that might happen?

[dani]

I think that ASP.NET receives in a short time 2 petitions to the httphandler and it has to create 2 MindTouch.Dream.Http.HttpHandler classes because the first petition needs a longer time to proceed.
Then the synchronization code in the constructor does not work because the SyncRoot object is not static, and each object constructs its IDreamEnvironment _env, each one with all his initialitzations.
If you change the code making SyncRoot static the problem of the first call disappears, but when ASP.NET needs to process 2 concurrent petitions it constructs another httphandler (I think it uses a pool of handler classes) and creates another environtment.
I think the solution is to define both SyncRoot and _env static, but I'm not sure if this is correct for all the situations.

[SteveB]

Hmm, I wonder what is the recommended fix here. I mean what if we did want two handlers, because there are multiple entry points at once. At least, that's supported by mindtouch.dream.host.exe. I don't know if IIS would support it as well.

[SteveB]

I fix for this issue was checked in today: http://bugs.developer.mindtouch.com/view.php?id=5520